Catch errors thrown by pcap #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pcap throws errors in a variety of decoding operations*, we catch them when we're doing the packet decoding and then just proceed like normal. * See https://github.com/mranney/node_pcap/search?utf8=%E2%9C%93&q=%22throw+new%22
…erfaces are available" from impacting tests further down the line.
hortinstein
added a commit
that referenced
this pull request
Jan 19, 2016
Catch errors thrown by pcap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2% of this change is just adding a try/catch inside of pcap_session.on('packet')
The rest is adjusting the mock-test suite to permit testing of this change (primarily to isolate the "should throw an error if no interfaces are available" mechanism from having negative impacts on other tests further down the line)