Create Manufacturer Listing Feature in findbutton #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the difficulty that occurs using this software to connect to Amazon Dash Buttons occurs because the findbutton script relays the related MAC address of all arp packets that it detects, not just the ones that could belong to Dash Buttons. This change makes findbutton easier to use by looking up the MAC address header oui as registered with the IEEE and, if the identified MAC address belongs to a manufacturer, it will display the name after the address. This means that it should be easier to identify whether the addresses received belong to the Amazon Dash Buttons or any other device on your network.