ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able but with default value
guruchai
reviewed
Dec 5, 2019
|
|
||
| for (Schema.Field field : fields) { | ||
| Schema fieldSchema = field.schema(); | ||
| // check for union | ||
|
|
||
| boolean currentFieldTypeIsUnion = fieldSchema.getType() == Schema.Type.UNION; | ||
| Object defaultValue = field.defaultVal(); | ||
| if (currentFieldTypeIsUnion) { | ||
| // check for the fields with in union | ||
| // if it is union and first type is null then set default value as null | ||
| if (fieldSchema.getTypes().get(0).getType() == Schema.Type.NULL) { |
There was a problem hiding this comment.
Is it assumed or guaranteed that null type comes first?
guruchai
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Extending the example given in the Issue
- If geoAddress is null at serializer side, what do you get on deserialization for geoAddress?
- If geoAddress is not set at all on serializer side, what do you get on deserialization for geoAddress?
Can you add unit tests around this?
…efaults correctly
|
@guruchai : I have test to check if avro schema resolver is taking defaults for unions |
|
LGTM.... |
raju-saravanan
added a commit
that referenced
this pull request
Dec 6, 2019
…ble but with default value (#636) * ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value * Add test cases to check schema registry is parsing the unions with defaults correctly
gkomlossi
pushed a commit
that referenced
this pull request
Jun 24, 2021
…ble but with default value (#636) * ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value * Add test cases to check schema registry is parsing the unions with defaults correctly
gkomlossi
pushed a commit
that referenced
this pull request
Jun 24, 2021
…hat is nullable but with default value (#636) * ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value * Add test cases to check schema registry is parsing the unions with defaults correctly
pnagy-cldr
pushed a commit
that referenced
this pull request
Sep 30, 2021
…hat is nullable but with default value (#636) * ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value * Add test cases to check schema registry is parsing the unions with defaults correctly
gkomlossi
pushed a commit
that referenced
this pull request
Dec 16, 2021
…hat is nullable but with default value (#636) * ISSUE-633 : Fix error when creating a schema with field that is nullable but with default value * Add test cases to check schema registry is parsing the unions with defaults correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633