-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-85 Changed the UI to add schema for better UX experience #86
Conversation
+1 Looks good. Thanks for the PR @satishwaghela. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message given in SchemaText box seems to have large font and it does not look right to me. We may want to have font size same or slightly bigger than other text in the page.
This textbox area looks similar to google ads on a web page.
You may want to remove "Type or Drop a file" text besides SCHEMA TEXT as user message is already given on that are.
@satishd I have addressed your comment. please review the changes, thanks |
@satishwaghela @shahsank3t we need to make Evolve bit more than a check box or at least provide some text what that means. If they uncheck it lets show at the bottom of that check box in orange/yellow color that the new schema versions cannot be added. |
@harshach - I have kept check box as it is and added a message besides when untick as seen in the attached image. |
Thanks @satishwaghela above looks good for evolve. Also it would be good to have option to expand the schema text area. |
@harshach , I have added expand/collapse button for schema text. please have a look. |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM. UI looks much better than earlier.
Have we thought about option of having 3/4 area for schema text and 1/4 area for the left column about name/type/compatibility etc and description can be two rows resizable textbox?
I am fine with merging this PR but the above question can be discussed here or as a new issue.
Raised issue #100 to discuss on the comment. |
Changed Schema text label, font size of content and fixed validation Added warning on evolve uncheck Added expand/collapse button on add schema form
@satishd, I have squashed commits. |
Thanks @satishwaghela |
No description provided.