Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-85 Changed the UI to add schema for better UX experience #86

Merged
merged 1 commit into from
May 10, 2017
Merged

ISSUE-85 Changed the UI to add schema for better UX experience #86

merged 1 commit into from
May 10, 2017

Conversation

satishwaghela
Copy link
Contributor

No description provided.

@shahsank3t
Copy link
Contributor

+1 Looks good. Thanks for the PR @satishwaghela.

Copy link
Contributor

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message given in SchemaText box seems to have large font and it does not look right to me. We may want to have font size same or slightly bigger than other text in the page.
This textbox area looks similar to google ads on a web page.

You may want to remove "Type or Drop a file" text besides SCHEMA TEXT as user message is already given on that are.

screen shot 2017-05-06 at 7 16 50 am

@satishwaghela
Copy link
Contributor Author

@satishd I have addressed your comment. please review the changes, thanks

@harshach
Copy link
Contributor

harshach commented May 8, 2017

@satishwaghela @shahsank3t we need to make Evolve bit more than a check box or at least provide some text what that means. If they uncheck it lets show at the bottom of that check box in orange/yellow color that the new schema versions cannot be added.

@satishwaghela
Copy link
Contributor Author

imgpsh_fullsize 3

@harshach - I have kept check box as it is and added a message besides when untick as seen in the attached image.
We can either keep checkbox or go with the toggle button saying “Yes / No” but I guess checkbox is sufficient.

@harshach
Copy link
Contributor

harshach commented May 8, 2017

Thanks @satishwaghela above looks good for evolve. Also it would be good to have option to expand the schema text area.

@satishwaghela
Copy link
Contributor Author

@harshach , I have added expand/collapse button for schema text. please have a look.

@harshach
Copy link
Contributor

harshach commented May 9, 2017

+1

Copy link
Contributor

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. UI looks much better than earlier.

Have we thought about option of having 3/4 area for schema text and 1/4 area for the left column about name/type/compatibility etc and description can be two rows resizable textbox?

I am fine with merging this PR but the above question can be discussed here or as a new issue.

@shahsank3t
Copy link
Contributor

@satishd @harshach I would suggest to merge this PR and continue the discussion on a new issue so at least this new changes gets to the user.

@satishd
Copy link
Contributor

satishd commented May 10, 2017

Raised issue #100 to discuss on the comment.
@satishwaghela Can you squash these commits? I will merge this PR once that is done.

Changed Schema text label, font size of content and fixed validation

Added warning on evolve uncheck

Added expand/collapse button on add schema form
@satishwaghela
Copy link
Contributor Author

@satishd, I have squashed commits.

@hortonjenkins hortonjenkins merged commit d37cb90 into hortonworks:master May 10, 2017
@satishd
Copy link
Contributor

satishd commented May 10, 2017

Thanks @satishwaghela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants