Skip to content

Commit

Permalink
Fetch 30 -> 100 events
Browse files Browse the repository at this point in the history
  • Loading branch information
hoshinotsuyoshi committed Jul 14, 2015
1 parent 7fa4aca commit 9d90dc8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/github/nippou.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Nippou
def self.list
user = self.user
client = Octokit::Client.new(login: user, access_token: self.access_token)
events = client.user_events(user)
events = client.user_events(user, per_page: 100)

url_to_detail = {}

Expand Down

3 comments on commit 9d90dc8

@masutaka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

オプションにしようかなあ。
Time.now.to_date も気になってます(昨日の日報が書けない)。

@hoshinotsuyoshi
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masutaka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-n オプションを追加してみました。指定しないと 50 です。
100 だと 20 秒とかかかったので、この辺で妥協。
Paginataion をちゃんと参照すれば、もっと良い感じにできるのかも。

github-nippou v1.1.0 and v1.1.1 released / マスタカの ChangeLog メモ

Please sign in to comment.