Rename enableCellValueTrim to setShouldTrim

hoshomoh · Dec 23, 2021 · 0045669 · 0045669
1 parent 6c96eaf
commit 0045669
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Validator/Validator.php b/src/Validator/Validator.php
@@ -103,7 +103,7 @@ class Validator
      *
      * @var bool
      */
-    protected $trimCells = false;
+    protected $shouldTrim = false;
 
     /**
      * The array of custom error messages.
@@ -185,7 +185,7 @@ protected function passes(): bool
                 while (false !== ($row = fgetcsv($handle, 0, $this->delimiter))) {
                     ++$this->currentRowLineNumber;
 
-                    if ($this->trimCells) {
+                    if ($this->shouldTrim) {
                         $row = array_map('trim', $row);
                     }
 
@@ -434,8 +434,8 @@ protected function getValue(string $attribute)
      *
      * @return void
      */
-    public function enableCellValueTrim(bool $trimValues = false)
+    public function setShouldTrim(bool $shouldTrim = false)
     {
-        $this->trimCells = $trimValues;
+        $this->shouldTrim = $shouldTrim;
     }
 }
diff --git a/tests/src/CsvValidatorTest.php b/tests/src/CsvValidatorTest.php
@@ -45,7 +45,7 @@ public function testAlphaValidationRule()
             'contact' => ['alpha'],
         ]);
 
-        $validator->enableCellValueTrim(true);
+        $validator->setShouldTrim(true);
 
         $this->assertTrue($validator->fails());
 
@@ -74,7 +74,7 @@ public function testAlphaNumValidationRule()
             'contact' => ['alpha_num'],
         ]);
 
-        $validator->enableCellValueTrim(true);
+        $validator->setShouldTrim(true);
 
         $this->assertTrue($validator->fails());