Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 5 #29

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Symfony 5 #29

merged 2 commits into from
Mar 6, 2020

Conversation

GwendolenLynch
Copy link
Contributor

@GwendolenLynch GwendolenLynch commented Oct 24, 2019 •
edited

I had a bit of time, and November is fast approaching. 馃帀

  • Updated Symfony constraints to include ^5.0
  • Updated PHPUnit constraint to include ^7.5
  • Updated PHPUnit TestCase namespaces to match

Notes:

  • symfony/debug is being removed/replaced in Symfony 5, but forward compat. comes in 4.4

For local testing:

       "symfony/form":            "dev-master@dev",
       "symfony/http-foundation": "dev-master@dev"
       "symfony/debug":          "4.4.x-dev@dev",
       "symfony/phpunit-bridge": "dev-master@dev"

Let me know if you want anything more.

@GwendolenLynch
Update PHPUnit for forward compatibility
b5daee9 
- PHPUnit namespaces
- Tests mocks as FormFactoryInterface requires a type
@GwendolenLynch
Update constraints to allow Symfony 5
55fe584
@GwendolenLynch GwendolenLynch mentioned this pull request Oct 24, 2019
Merged
@yannickl88
Copy link
Member

Thanks for the PR! I will have a look at it as soon as I have some time.

mvannes
mvannes approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@mvannes mvannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, really sorry about this incredible delay. There's some small conflicts now due to us responding to our own pull requests but somehow not yours.
Very sorry about that again, as this looks great!
It's got my approval if the conflicts are fixed

@GwendolenLynch
Copy link
Contributor Author

Rebased and passing test locally. 馃憤

@mvannes
Copy link
Contributor

mvannes commented Mar 6, 2020

Great, I'll look at it again Monday, and I'll assume it's fine and merge and tag then! Thank you for your help!

yannickl88
yannickl88 approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@yannickl88 yannickl88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, apologies for the delay. I will merge this now. Thanks for contributing!

@yannickl88 yannickl88 merged commit e8e7a78 into hostnet:master Mar 6, 2020
@yannickl88
Copy link
Member

I've created v1.7.0 to include these changes

@GwendolenLynch GwendolenLynch deleted the symfony-5 branch March 7, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannickl88 yannickl88 yannickl88 approved these changes

@mvannes mvannes mvannes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GwendolenLynch @yannickl88 @mvannes