forked from jjideenschmiede/golexoffice
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2 from hostwithquantum/handle-errors
handle errors
- Loading branch information
Showing
7 changed files
with
214 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package golexoffice | ||
|
|
||
| // source: https://developers.lexoffice.io/docs/#error-codes-legacy-error-response | ||
| // files, profile, contacts | ||
| // | ||
| // { | ||
| // "requestId":"3fb21ee4-ad26-4e2f-82af-a1197af02d08", | ||
| // "IssueList":[ | ||
| // {"i18nKey":"invalid_value","source":"company and person","type":"validation_failure"}, | ||
| // {"i18nKey":"missing_entity","source":"company.name","type":"validation_failure"} | ||
| // ] | ||
| // } | ||
| type LegacyErrorResponse struct { | ||
| RequestId string `json:"requestId"` | ||
| IssueList []struct { | ||
| Key string `json:"i18nKey"` | ||
| Source string `json:"source"` | ||
| Type string `json:"type"` | ||
| } `json:"IssueList"` | ||
| } | ||
|
|
||
| // source: https://developers.lexoffice.io/docs/#error-codes-regular-error-response | ||
| // event-subscription, invoices | ||
| // | ||
| // { | ||
| // "timestamp": "2017-05-11T17:12:31.233+02:00", | ||
| // "status": 406, | ||
| // "error": "Not Acceptable", | ||
| // "path": "/v1/invoices", | ||
| // "traceId": "90d78d0777be", | ||
| // "message": "Validation failed for request. Please see details list for specific causes.", | ||
| // "details": [ | ||
| // { | ||
| // "violation": "NOTNULL", | ||
| // "field": "lineItems[0].unitPrice.taxRatePercentage", | ||
| // "message": "darf nicht leer sein" | ||
| // } | ||
| // ] | ||
| // } | ||
| type ErrorResponse struct { | ||
| Timestamp string `json:"timestamp"` // FIXME: should be a date thing | ||
| Status int `json:"status"` | ||
| Error string `json:"error"` | ||
| Path string `json:"path"` | ||
| TraceID string `json:"traceId"` | ||
| Message string `json:"message"` | ||
| Details []struct { | ||
| Violation string `json:"violation"` | ||
| Field string `json:"field"` | ||
| Message string `json:"message"` | ||
| } `json:"details"` | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package golexoffice_test | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/hostwithquantum/golexoffice" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| // {"requestId":"3fb21ee4-ad26-4e2f-82af-a1197af02d08","IssueList":[{"i18nKey":"invalid_value","source":"company and person","type":"validation_failure"},{"i18nKey":"missing_entity","source":"company.name","type":"validation_failure"}]} | ||
|
|
||
| // {"requestId":"75d4dad6-6ccb-40fd-8c22-797f2d421d98","IssueList":[{"i18nKey":"missing_entity","source":"company.vatRegistrationId","type":"validation_failure"},{"i18nKey":"missing_entity","source":"company.taxNumber","type":"validation_failure"}]} | ||
|
|
||
| func TestErrorResponse(t *testing.T) { | ||
| server := errorMock() | ||
| defer server.Close() | ||
|
|
||
| lexOffice := golexoffice.NewConfig("token", nil) | ||
| lexOffice.SetBaseUrl(server.URL) | ||
|
|
||
| t.Run("errors=legacy", func(t *testing.T) { | ||
| _, err := lexOffice.AddContact(golexoffice.ContactBody{ | ||
| Company: &golexoffice.ContactBodyCompany{ | ||
| Name: "company", | ||
| VatRegistrationId: "", | ||
| TaxNumber: "", | ||
| }, | ||
| }) | ||
| assert.Error(t, err) | ||
| }) | ||
|
|
||
| t.Run("errors=new", func(t *testing.T) { | ||
| _, err := lexOffice.AddInvoice(golexoffice.InvoiceBody{}) | ||
| assert.Error(t, err) | ||
| }) | ||
|
|
||
| } | ||
|
|
||
| func errorMock() *httptest.Server { | ||
| return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/v1/contacts" { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| //nolint:errcheck | ||
| w.Write([]byte(`{ | ||
| "requestId":"75d4dad6-6ccb-40fd-8c22-797f2d421d98", | ||
| "IssueList":[ | ||
| {"i18nKey":"missing_entity","source":"company.vatRegistrationId","type":"validation_failure"}, | ||
| {"i18nKey":"missing_entity","source":"company.taxNumber","type":"validation_failure"} | ||
| ] | ||
| }`)) | ||
| return | ||
| } | ||
| if r.URL.Path == "/v1/invoices" { | ||
| w.WriteHeader(http.StatusNotAcceptable) | ||
| //nolint:errcheck | ||
| w.Write([]byte(`{ | ||
| "timestamp": "2017-05-11T17:12:31.233+02:00", | ||
| "status": 406, | ||
| "error": "Not Acceptable", | ||
| "path": "/v1/invoices", | ||
| "traceId": "90d78d0777be", | ||
| "message": "Validation failed for request. Please see details list for specific causes.", | ||
| "details": [ | ||
| { | ||
| "violation": "NOTNULL", | ||
| "field": "lineItems[0].unitPrice.taxRatePercentage", | ||
| "message": "darf nicht leer sein" | ||
| } | ||
| ] | ||
| }`)) | ||
| return | ||
| } | ||
| w.WriteHeader(http.StatusNotFound) | ||
| })) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/hostwithquantum/golexoffice | ||
|
|
||
| go 1.19 | ||
| go 1.20 | ||
|
|
||
| require github.com/stretchr/testify v1.8.2 | ||
|
|
||
|
|
||