Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2005. Fix back functionality when viewing bookmarks #2

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

hosungh
Copy link
Owner

@hosungh hosungh commented Mar 17, 2020

Note: a simple use of :back would not have worked as there would have been a circuitous flow between creating a new bookmark and attempting to go back to student_task/view?id=num

@@ -82,7 +82,9 @@
<br />

<%= link_to 'New bookmark', :action => 'new', :id => @topic.id %> |
<%= link_to 'Back', :controller=> 'sign_up_sheet', :action=>'list', :assignment_id => @topic.assignment_id %>
<%= link_to 'Back', '#', :onclick => 'pageBack()' %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what does the pound sign do here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used when you want to link back to the page itself. It fails to work otherwise for some reason

@hosungh hosungh merged commit 77fd145 into beta Mar 17, 2020
adityag3 pushed a commit that referenced this pull request Jun 17, 2020
testing the first test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants