@OnNeverAskAgain not being called

[emarc-m]

Annotating a method with @OnNeverAskAgain is not called. What is called is the method annotated with @OnPermissionDenied.

I think the generated code conditions checks are incorrect.

static void onRequestPermissionsResult(BaseActivity target, int requestCode, int[] grantResults) {
    switch (requestCode) {
      case REQUEST_INITIALIZESCANNING:
      // this would always be true if the permission was denied and on never ask again
      if (!PermissionUtils.hasSelfPermissions(target, PERMISSION_INITIALIZESCANNING)) {
        target.showDenied();
        return;
      }
      if (PermissionUtils.verifyPermissions(grantResults)) {
        target.initializeScanning();
      } else {
        if (!PermissionUtils.shouldShowRequestPermissionRationale(target, PERMISSION_INITIALIZESCANNING)) {
          target.showNeverAsk(); // this is NEVER called
        } else {
          target.showDenied();
        }
      }
      break;
      default:
      break;
    }
  }

Thanks. Great work BTW.

[hotchemi]

@emarc-m Ah, could u use 2.0.2 for the time being? It might works well. So sorry!

[emarc-m]

@hotchemi Thanks for that info.

[shiraji]

It's time to add functional tests.

[hotchemi]

Right code is as follows.

static void onRequestPermissionsResult(BaseActivity target, int requestCode, int[] grantResults) {
    switch (requestCode) {
      case REQUEST_INITIALIZESCANNING:
+     // Never ask again is never shown if Build.VERSION. SDK_INT is under 23 
+     if (Build.VERSION. SDK_INT < 23 && !PermissionUtils.hasSelfPermissions(target, PERMISSION_INITIALIZESCANNING)) {
        target.showDenied();
        return;
      }
      if (PermissionUtils.verifyPermissions(grantResults)) {
        target.initializeScanning();
      } else {
        if (!PermissionUtils.shouldShowRequestPermissionRationale(target, PERMISSION_INITIALIZESCANNING)) {
          target.showNeverAsk(); // this is NEVER called
        } else {
          target.showDenied();
        }
      }
      break;
      default:
      break;
    }
  }

[hotchemi]

@shiraji Might be the good idea but it takes a bunch of cost...worrisome problem.

[shiraji]

Wait, I think there is one more problem. PermissionDispatcher must take care of SYSTEM_ALERT_WINDOW and WRITE_SETTINGS.

This test case is not correct. Should be following:

if (!Settings.System.canWrite(target)) 

This line should check if it is in ADD_WITH_CHECK_BODY_MAP

We need to refactor fun addHasSelfPermissionsCondition(builder: MethodSpec.Builder, activityVar: String) as well in order to take care of this one.

Do you want me to send pull request for this?

[hotchemi]

@shiraji Umm, actually this line is just workaround for under M devices. See #45 (comment) .

I'm not sure the same thing happens in SYSTEM_ALERT_WINDOW and WRITE_SETTINGS.
So, we should delete this line when exceptional permissions case.

Do you want me to send pull request for this?

Sure!

[shiraji]

So, we should delete this line when exceptional permissions case.

That makes life easier!

[hotchemi]

@emarc-m Just released 2.0.4. Really appreciated for your report.

[emarc-m]

@hotchemi Thanks for the support.