Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with @OnNeverAskAgain #79

Merged

Conversation

shiraji
Copy link
Member

@shiraji shiraji commented Jan 21, 2016

see #78

@hotchemi
Copy link
Member

@shiraji Thx! I've not tasted it but Build.VERSION_CODES.M might cause compile error when device os is under M. Right?

@shiraji
Copy link
Member Author

shiraji commented Jan 21, 2016

Right. let me replace with 23.

@shiraji
Copy link
Member Author

shiraji commented Jan 21, 2016

Fixed it and squashed

@mannodermaus
Copy link
Contributor

Build.VERSION_CODES.M doesn't cause issues with pre-Marshmallow devices, because these constants are being provided by the SDK level used for compilation, rather than the target SDK level on the device. They get replaced by their numerical value during the compilation step

@shiraji
Copy link
Member Author

shiraji commented Jan 21, 2016

I'm ready for force push, again!

Maybe I am too sleepy to think carefully. Actually, my company's app uses Build.VERSION_CODES.KITKAT to find if the running device is under 19 or not without any error report.

@hotchemi
Copy link
Member

Oh sorry, I'm gonna test it and merge.
Anyway really appreciated for your great work!

@shiraji
Copy link
Member Author

shiraji commented Jan 21, 2016

Do you want me to revert the change? I haven't push it yet.

hotchemi added a commit that referenced this pull request Jan 21, 2016
@hotchemi hotchemi merged commit ca984e3 into permissions-dispatcher:master Jan 21, 2016
@shiraji shiraji deleted the 78_fix_OnNeverAskAgain branch January 21, 2016 23:21
@hotchemi
Copy link
Member

Umm, it didn't go well...I have to investigate more.

@shiraji
Copy link
Member Author

shiraji commented Jan 22, 2016

From initial comment.

App's targetSdkVersion is under 23 and device os is 6.0

I don't see any implementation for targetSdkVersion is under 23

Build.VERSION.SDK_INT < 23 is for runtime. It checks device os is under 6.0. It doesn't check if its targetSdkVersion is less than 23, does it?

@hotchemi
Copy link
Member

Exactly, I'm fixing it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants