Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dates.of() with one-biased day #13

Closed
martinbrylski opened this issue Nov 14, 2016 · 0 comments
Closed

Dates.of() with one-biased day #13

martinbrylski opened this issue Nov 14, 2016 · 0 comments

Comments

@martinbrylski
Copy link

martinbrylski commented Nov 14, 2016 •
edited

Day of month in Javas calendar starts with 1 not with 0. So the day -1 in Dates.kt is wrong.

As there is also a Test it might be intended. But I think it is misleading to write Dates.of(day=21) and expect the calendar date to be 20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hotchemi @martinbrylski