Changes to better reflect Java Calendar API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to 24h API → use HOUR_OF_DAY Changed DATE (DAY_OF_MONTH) to start at 1 (not zero based like month) Fixed tests to reflect new api
|
This is an opinionated better usage of the api which adresses #13 |
|
Seems there must be some locale specific configuration be done. I will investigate it further... |
|
Thx! Let me check later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to 24h API → use HOUR_OF_DAY
Changed DATE (DAY_OF_MONTH) to start at 1 (not zero based like month)
Fixed tests to reflect new api