Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Events API #10

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

bobbyg603
Copy link
Contributor

Fixes #9

@bobbyg603 bobbyg603 changed the title Adds support for Event API feature: Add support for Events API Nov 12, 2021
@bobbyg603
Copy link
Contributor Author

hi @hereismass, is this repo accepting contributions? do you need anything else from me to get this merged? please let me know.

@hereismass
Copy link
Member

Hey, sorry for the delay, did not see the PR :)
the changes looks good.

cc @arrwhidev for approval as I am not working on this area anymore

@bobbyg603
Copy link
Contributor Author

@hereismass thank you!

@bobbyg603 bobbyg603 changed the title feature: Add support for Events API feat: Add support for Events API Nov 19, 2021
@arrwhidev
Copy link
Contributor

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

@bobbyg603
Copy link
Contributor Author

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

Sure thing, I'll amend the commit in the near future. Thanks for the review!

@bobbyg603
Copy link
Contributor Author

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

Hi @arrwhidev, I've amended the commit. I think logging an event for an error is a really powerful use case (we use this a lot at BugSplat), however, I'll admit it's a bit awkward to click the button and see a danger alert in the demo. Please let me know if you'd like me to show a different example. Thanks!

@bobbyg603
Copy link
Contributor Author

Hi @arrwhidev would love to get this merged so we could use the official hotjar package and deprecate our custom version. Please let me know if you need anything from me in order to get this merged. Thanks!

@arrwhidev arrwhidev merged commit 29363d7 into hotjar:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Events API
3 participants