This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer - I did this all in the GitHub editor. I didn't actually test it, so you'll probably want to check it out.
While I was doing statamic/cms#5302 for Statamic 3.3, I went looking on GitHub for usages of
augmentValue()
and noticed this.template
,$this->augmentedValue('template')
would have been aValue
instance, so this condition would always befalse
.template
,$this->augmentedValue('template')
will be aValue
instance, again making this condition alwaysfalse
.template()
method to get the plain template name.instanceof
check to first, so you can be sure thetemplate()
method will be available to use since you'll know it's aPage
orEntry
already.