Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of Devise bug fixes #84

Merged
merged 2 commits into from
May 8, 2023
Merged

A couple of Devise bug fixes #84

merged 2 commits into from
May 8, 2023

Conversation

nathanmsmith
Copy link
Member

Description

  • Fix broken sign_in link
  • Remember users after they log in

Deployment

  • I am making a frontend change, which will be auto-deployed via Heroku.
  • I am making a Ruby change, which will be auto-deployed via Heroku.
    • I have added one or more gems, and run rake sorbet:update:all to generate their types.
    • I have added or changed a model, and run rake sorbet:update:all to generate their types.
  • I am making a database change, which I will manually deploy after my branch is merged.
    • I have migrated the database using env RAILS_ENV=production rails db:migrate.
    • I have updated the entity relationship diagram via bundle exec erd.
    • I have updated the affected Administrate model dashboards to reflect my DB changes.
  • I am making a Go Lambda change, which I will manually deploy after my branch is merged.
    • I have deployed the lambdas using make deploy.
  • There are other deployment steps I must take after merge, which are:

@nathanmsmith nathanmsmith merged commit 0181d0d into main May 8, 2023
1 check failed
@nathanmsmith nathanmsmith deleted the nathan/devise-tweaks branch May 8, 2023 05:26
nathanmsmith added a commit that referenced this pull request Aug 3, 2023
* Fix sign_in, sign_out routes

* Remember users on login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant