New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i18n setup, tests passing #237
Conversation
please note that this commit breaks things. it's a save point.
Can we get some documentation on exactly what needs to be done regarding deployment? I know we talked about this, but I don't remember. I'll pull this in after that. |
I'm not quite sure if that's what you're looking for. I think we'd talked about building the mo files on deployment -- that's probably not necessary yet, if at all, unless you'd rather not have them in your source tree (they're binary files). |
I just remembered we'd kinda talked about it, but not really. I think leaving them in the tree is fine for now, once we stabilize and actually work on getting translations for real, we can worry about minimizing the size. Two files is no biggie. |
Getting one test failure:
|
Strange. WFFM. Just in my branch or when you merge? I'll try on my other dev machine in a few minutes. |
Just your branch. merged it in minutes ago. |
Added remember me checkbox to login page. POST to /login sets session variable remember_me to true when the checkbox was checked on signin Created an extension of Rack::Session::Cookie that sets the cookie expiry based on session variables remember_me and used_id
User model validation of username field is now case insenstive Added unit test for case insensitive username unicity during save Added rake tasks: * fixdb:undup_usernames to repair duplicate users * fixdb:report_duplicate_usernames to report on duplicate usernames
Updated unit test for this method to ensure that it works as advertised. [#24 state:resolved]
selected when running acceptance tests
... Except for config.ru, because that makes us add arguments to rackup, and that just plain sucks.
Pulled in upstream. Problem test seems to fail ~1/30 times. Baffled. |
Merged into a feature branch, i18n. :) |
Verified, and merged up to HEAD as of like 10 minutes ago.