Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n setup, tests passing #237

Closed
wants to merge 31 commits into from
Closed

Update i18n setup, tests passing #237

wants to merge 31 commits into from

Conversation

colindean
Copy link
Contributor

Verified, and merged up to HEAD as of like 10 minutes ago.

@steveklabnik
Copy link
Contributor

Can we get some documentation on exactly what needs to be done regarding deployment? I know we talked about this, but I don't remember.

I'll pull this in after that.

@colindean
Copy link
Contributor Author

I'm not quite sure if that's what you're looking for.

I think we'd talked about building the mo files on deployment -- that's probably not necessary yet, if at all, unless you'd rather not have them in your source tree (they're binary files).

@steveklabnik
Copy link
Contributor

I just remembered we'd kinda talked about it, but not really.

I think leaving them in the tree is fine for now, once we stabilize and actually work on getting translations for real, we can worry about minimizing the size. Two files is no biggie.

@steveklabnik
Copy link
Contributor

Getting one test failure:

  1. Failure:
    test_translation_language_detection(TranslationsTest) [test/acceptance/translation_test.rb:23]:
    Expected /Komunigu/

@colindean
Copy link
Contributor Author

Strange. WFFM.

Just in my branch or when you merge?

I'll try on my other dev machine in a few minutes.

@steveklabnik
Copy link
Contributor

Just your branch. merged it in minutes ago.

mrkcor and others added 12 commits April 12, 2011 22:35
Added remember me checkbox to login page.
POST to /login sets session variable remember_me to true
when the checkbox was checked on signin
Created an extension of Rack::Session::Cookie that sets the cookie
expiry based on session variables remember_me and used_id
User model validation of username field is now case insenstive
Added unit test for case insensitive username unicity during save
Added rake tasks:
* fixdb:undup_usernames to repair duplicate users
* fixdb:report_duplicate_usernames to report on duplicate usernames
Updated unit test for this method to ensure that it works as advertised.

[#24 state:resolved]
... Except for config.ru, because that makes us add arguments to rackup,
and that just plain sucks.
@colindean
Copy link
Contributor Author

Pulled in upstream. Problem test seems to fail ~1/30 times. Baffled.

@steveklabnik
Copy link
Contributor

Merged into a feature branch, i18n. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants