Fixed: firebase project ID error on login due to missing configs in firebase-messaging-sw #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase-messaging-sw
ymaheshwari1
requested changes
Oct 6, 2023
public/firebase-messaging-sw.js
Outdated
| // wrapping the logic inside function and calling it | ||
| // to provide return statement support | ||
| handleFirebaseInit() |
There was a problem hiding this comment.
Suggested change
| handleFirebaseInit() | |
| initFirebase() |
There was a problem hiding this comment.
Used an IIFE instead.
ymaheshwari1
approved these changes
Oct 10, 2023
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 16, 2024
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 16, 2024
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 17, 2024
ymaheshwari1
added a commit
that referenced
this pull request
Apr 19, 2024
Fixed: infinite scroll issue when used with searchbar(dxp-289)
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 22, 2024
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 22, 2024
R-Sourabh
added a commit
to R-Sourabh/bopis
that referenced
this pull request
Apr 22, 2024
ymaheshwari1
added a commit
that referenced
this pull request
Apr 22, 2024
Fixed: Infinite scroll with searchbar and loading bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Fixed project ID missing error on login due to missing firebase config values in the firebase service worker file.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance