Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: notification issues in bopis (#274) #375

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Feb 5, 2024

Related Issues

Related Issue: #274

Short Description and Why It's Useful

Fixed following issue:

  • Notification preferences not updating on facility change.
  • Improved logic to update notification specific to user.
  • Implemented loader on notificaiton preference update action.

Remaining issue:
Currently when user login to app, the notifications works fine. But once user refreshes the app post login. The firebase initialisation logic written in dxp-components doesn't work resulting in following issues:

  • Notifications not coming up when user is in app.
  • Notifications are not added to notifications tab of the app on opening on click of background alert notification.

Probable reason: Firebase initialisation is written in dxp-component which is called on login but when app refreshes that inititialisation reference gets lost and events for notification listening on dxp-component doesn't work.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi merged commit 132dbf4 into hotwax:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants