Implemented functionality for find order page ( #1wn444v ) #4
Conversation
src/components/OrderCard.vue
Outdated
| @@ -0,0 +1,115 @@ | |||
| <template> | |||
| <div class="order-header"> | |||
src/components/OrderCard.vue
Outdated
| IonNote, | ||
| OpenItemCard, | ||
| }, | ||
| props: ['order'], |
src/router/index.ts
Outdated
| // name: 'ProductInventory', | ||
| // component: ProductInventory, | ||
| // beforeEnter: authGuard | ||
| // }, |
There was a problem hiding this comment.
Remove this if not needed.
…e to get image url, size and color of product(#1wn444v)
… do not need to delete package-log.json again and again (#1wn444v)
…o that i do not need to delete package-log.json again and again (#1wn444v)" This reverts commit f1d38a7.
…ing method and shipping from (#1wn444)
| IonThumbnail, | ||
| IonTitle, | ||
| IonToolbar, | ||
| IonSelectOption, |
There was a problem hiding this comment.
Arrange the component import alphabetically
src/main.ts
Outdated
| @@ -57,7 +57,7 @@ app.config.globalProperties.$filters = { | |||
| externalId = externalIdentificationSplit[1] ? externalIdentificationSplit[1] : ''; | |||
| } | |||
| return externalId; | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
Remove this unwanted change
| @@ -40,12 +40,48 @@ const actions: ActionTree<ProductState, RootState> = { | |||
| // Remove added loader only when new query and not the infinite scroll | |||
| if (payload.viewIndex === 0) emitter.emit("dismissLoader"); | |||
| } catch(error){ | |||
| console.log(error) | |||
There was a problem hiding this comment.
Why we have removed this console statement?
There was a problem hiding this comment.
Aditya sharma Sir instructed me to remove all console.log from code before making PR.
There was a problem hiding this comment.
But this console statement is not added by you and it's used to display the error message
| products: { | ||
| list: any; | ||
| total: number; | ||
| } | ||
| productsInformation: any; |
There was a problem hiding this comment.
I think this state is not needed.
There was a problem hiding this comment.
Sir according to me this statement is removed in recent commits please check those
src/store/modules/order/actions.ts
Outdated
|
|
||
| // Add Product information in cache | ||
|
|
||
| async getProductInformation(context, { orders }){ |
There was a problem hiding this comment.
Remove duplicate declaration of the same function. You have defined the getProductInformation here in the order action and also in the product action.
There was a problem hiding this comment.
Okay sir will update
src/store/modules/product/index.ts
Outdated
| products: { | ||
| list: {}, | ||
| total: 0 | ||
| } | ||
| }, | ||
| productsInformation: {} |
There was a problem hiding this comment.
Remove the productsInformation state.
There was a problem hiding this comment.
Already removed Sir
| }, | ||
| [types.PRODUCT_ADD_TO_CACHED_MULTIPLE] (state, payload) { | ||
| // TODO | ||
| if (payload.products) { |
| } | ||
| }, | ||
| [types.PRODUCT_ADD_TO_CACHED_MULTIPLE] (state, payload) { | ||
| // TODO |
There was a problem hiding this comment.
Why here a TODO statement?
src/views/Orders.vue
Outdated
| }, | ||
|
|
||
| methods: { | ||
| async getOrders(vSize, vIndex){ |
There was a problem hiding this comment.
Make vSize and vIndex optional.
There was a problem hiding this comment.
Sir made them optional
src/views/Orders.vue
Outdated
|
|
||
| }, | ||
| mounted() { | ||
| this.getOrders(10, 0); |
There was a problem hiding this comment.
We won't pass the view size and view index from the mounted hook
…order and made getOrder function's parameters optional (#1wn444v)
|
|
|
This pull request can not be accessed by me for making further changes so this is why I am closing this pull request. |
Added instructions for using SDK
Implemented functionality in find order page, I have used findOrder and searchProduct endpoint there and integrated all necessary functionalities but did not get some properties there.