Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for key events with autocomplete in Chrome #713

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/core/binding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@ export class Binding {
private willBeInvokedByEvent(event: Event): boolean {
const eventTarget = event.target

if (
!(event instanceof KeyboardEvent) &&
event instanceof Event &&
(event.type === "keydown" || event.type === "keyup")
) {
return false
}

if (event instanceof KeyboardEvent && this.action.shouldIgnoreKeyboardEvent(event)) {
return false
}
Expand Down
8 changes: 8 additions & 0 deletions src/tests/modules/core/action_keyboard_filter_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export default class ActionKeyboardFilterTests extends LogControllerTestCase {
<button id="button8" data-action="keydown.a->a#log keydown.b->a#log2"></button>
<button id="button9" data-action="keydown.shift+a->a#log keydown.a->a#log2 keydown.ctrl+shift+a->a#log3">
<button id="button10" data-action="jquery.custom.event->a#log jquery.a->a#log2">
<button id="button11" data-action="keydown.esc->a#log keydown.tab->a#log2 keyup.a->a#log3">
</div>
`

Expand Down Expand Up @@ -197,4 +198,11 @@ export default class ActionKeyboardFilterTests extends LogControllerTestCase {
await this.triggerEvent(button, "jquery.a")
this.assertActions({ name: "log2", identifier: "a", eventType: "jquery.a", currentTarget: button })
}

async "test ignore keydown event with input suggestion in Chrome"() {
const button = this.findElement("#button11")
await this.nextFrame
await this.triggerEvent(button, "keydown")
this.assertActions()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class ActionParamsCaseInsensitiveTests extends ActionParamsTests
async "test global event return element params where the action is defined"() {
this.actionValue = "keydown@window->CamelCase#log"
await this.nextFrame
await this.triggerEvent("#outside", "keydown")
await this.triggerKeyboardEvent("#outside", "keydown", { bubbles: true })

this.assertActions({ identifier: "CamelCase", params: this.expectedParamsForCamelCase })
}
Expand Down
2 changes: 1 addition & 1 deletion src/tests/modules/core/action_params_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class ActionParamsTests extends LogControllerTestCase {
async "test global event return element params where the action is defined"() {
this.actionValue = "keydown@window->c#log"
await this.nextFrame
await this.triggerEvent("#outside", "keydown")
await this.triggerKeyboardEvent("#outside", "keydown", { bubbles: true })

this.assertActions({ identifier: "c", params: this.expectedParamsForC })
}
Expand Down
4 changes: 2 additions & 2 deletions src/tests/modules/core/action_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ export default class ActionTests extends LogControllerTestCase {
}

async "test global actions"() {
await this.triggerEvent("#outside", "keydown")
await this.triggerKeyboardEvent("#outside", "keydown", { bubbles: true })
this.assertActions({ name: "log", eventType: "keydown" })
}

async "test nested global actions"() {
const innerController = this.controllers[1]
await this.triggerEvent("#outside", "keyup")
await this.triggerKeyboardEvent("#outside", "keyup", { bubbles: true })
this.assertActions({ controller: innerController, eventType: "keyup" })
}

Expand Down
8 changes: 4 additions & 4 deletions src/tests/modules/core/event_options_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export default class EventOptionsTests extends LogControllerTestCase {
async "test global once actions"() {
await this.setAction(this.buttonElement, "keydown@window->c#log:once")

await this.triggerEvent("#outside", "keydown")
await this.triggerEvent("#outside", "keydown")
await this.triggerKeyboardEvent("#outside", "keydown", { bubbles: true })
await this.triggerKeyboardEvent("#outside", "keydown", { bubbles: true })

this.assertActions({ name: "log", eventType: "keydown" })
}
Expand Down Expand Up @@ -132,7 +132,7 @@ export default class EventOptionsTests extends LogControllerTestCase {
await this.setAction(this.element, "keydown->c#log")
await this.setAction(this.buttonElement, "keydown->c#log2:stop")

await this.triggerEvent(this.buttonElement, "keydown")
await this.triggerKeyboardEvent(this.buttonElement, "keydown", { bubbles: true })

this.assertActions({ name: "log2", eventType: "keydown" })
}
Expand All @@ -157,7 +157,7 @@ export default class EventOptionsTests extends LogControllerTestCase {
async "test prevent option with explicit event"() {
await this.setAction(this.buttonElement, "keyup->c#log:prevent")

await this.triggerEvent(this.buttonElement, "keyup")
await this.triggerKeyboardEvent(this.buttonElement, "keyup", { bubbles: true, cancelable: true })

this.assertActions({ name: "log", eventType: "keyup", defaultPrevented: true })
}
Expand Down