Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong comparission in PathConfiguration #159

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix wrong comparission in PathConfiguration #159

merged 1 commit into from
Nov 13, 2023

Conversation

quaasi
Copy link
Contributor

@quaasi quaasi commented Nov 13, 2023 •
edited

I was browsing through the code to understand it better where I found this expression:

lhs.settings == lhs.settings

which should always evaluate to true.

So I guess this is not intended and created a fix according to the second part of the boolean expression (lhs.rules == rhs.rules)

@joemasilotti
Copy link
Member

Nice catch! Thanks for the PR.

@joemasilotti joemasilotti merged commit c9d060f into hotwired:main Nov 13, 2023
olivaresf added a commit that referenced this pull request Feb 12, 2024
@olivaresf
Merge remote-tracking branch 'origin/main' into preserve-visit-option…
da5fcec 
…s-response

* origin/main:
  Fix obious wrong boolean expression (#159)
  Replace Quick/Nimble with XCTest (#139)
pklatka pushed a commit to pklatka/turbo-ios that referenced this pull request Feb 23, 2024
@quaasi @pklatka
Fix obious wrong boolean expression (hotwired#159)
c566617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quaasi @joemasilotti