Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically run turbo:install:redis if Redis is available on the machine already #225

Closed
dhh opened this issue Aug 26, 2021 · 3 comments · Fixed by #226
Closed

Automatically run turbo:install:redis if Redis is available on the machine already #225

dhh opened this issue Aug 26, 2021 · 3 comments · Fixed by #226

Comments

@dhh
Copy link
Member

dhh commented Aug 26, 2021

You need Redis to use Turbo Streams. Would be nicer if it was turned on by default during turbo:install if Redis is detected on the system.
@ceritium
Copy link
Contributor

What are you thinking to detect if Redis is available?

Something like which redis-server will not work if Redis is running inside a container.
nc -zv localhost 6379 works on mac, probably on Linux, not sure on windows.

@dhh
Copy link
Member Author

dhh commented Aug 26, 2021

Doesn't have to work perfectly everywhere, because it's just for "rails new" invocation. So even a which redis-cli check would probably do. If it's not found, you just continue with the notice to do it yourself.

ceritium added a commit to ceritium/turbo-rails that referenced this issue Aug 26, 2021
@ceritium
Switch on Redis if available on turbo:install
3a3c0b0 
It checks (naively) if Redis is installed, in case affirmative it run
`turbo:install:redis`, otherwise print some information about how to do
it.

Closes hotwired#225
@ceritium ceritium mentioned this issue Aug 26, 2021
Merged
ceritium added a commit to ceritium/turbo-rails that referenced this issue Aug 26, 2021
@ceritium
Switch on Redis if available on turbo:install
0696245 
It checks (naively) if Redis is installed, in case affirmative it run
`turbo:install:redis`, otherwise print some information about how to do
it.

Closes hotwired#225
@ceritium
Copy link
Contributor

#226 address it

@dhh dhh closed this as completed in #226 Sep 1, 2021
dhh pushed a commit that referenced this issue Sep 1, 2021
@ceritium
Switch on Redis if available on turbo:install (#226)
111ca57 
It checks (naively) if Redis is installed, in case affirmative it run
`turbo:install:redis`, otherwise print some information about how to do
it.

Closes #225
@mohits mohits mentioned this issue Jan 22, 2022
Closed
atosbucket added a commit to atosbucket/turbo-rails that referenced this issue Apr 11, 2024
@atosbucket
Switch on Redis if available on turbo:install (#226)
868b6a7 
It checks (naively) if Redis is installed, in case affirmative it run
`turbo:install:redis`, otherwise print some information about how to do
it.

Closes hotwired/turbo-rails#225
newheaven918 added a commit to newheaven918/turbo that referenced this issue Apr 26, 2024
@newheaven918
Switch on Redis if available on turbo:install (#226)
cb3eca0 
It checks (naively) if Redis is installed, in case affirmative it run
`turbo:install:redis`, otherwise print some information about how to do
it.

Closes hotwired/turbo-rails#225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch on Redis if available on turbo:install ceritium/turbo-rails
2 participants
@dhh @ceritium