Should we expect this to work with rails button helper?

[chrisortman]

There's an example test case here: main...chrisortman:turbo-rails:main

There seem to be a few edge cases depending on your version of rails (different button helper behavior between 6 & 7)

My first question before going into details, should this work? Or is the expectation to create <button formmethod="delete">Delete me!</button> elements without using the FormHelper

[ocarreterom]

Using the Rails helper for forms submission are not working with formmethod attribute.

This code…

<%= form_with model: @model do |form| %>
  <%= form.button "Delete", formmethod: :delete %>
<% end %>

results in:

<form action="" method="post">
  <input type="hidden" name="_method" value="patch">

  <button type="submit" formmethod="post" name="_method" value="delete">Delete</button>
</form>

According to this function, always "post" will be returned since the value attribute for the <button> submitter is being ignored.

turbo-rails/app/javascript/turbo/fetch_requests.js

Lines 36 to 46 in ea00f37

	function determineFormMethod(submitter) {
	if (submitter instanceof HTMLButtonElement || submitter instanceof HTMLInputElement) {
	if (submitter.hasAttribute("formmethod")) {
	return submitter.formMethod
	} else {
	return null
	}
	} else {
	return null
	}
	}

[ocarreterom]

There is an open PR #445