Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate with Turbo Drive documentation outdated? #426

Closed
alexdelgado opened this issue Feb 2, 2023 · 1 comment
Closed

Navigate with Turbo Drive documentation outdated? #426

alexdelgado opened this issue Feb 2, 2023 · 1 comment

Comments

@alexdelgado
Copy link
Contributor

We were following the turbo-drive documentation in the README that says to do the following:

import { Turbo } from "@hotwired/turbo-rails"
Turbo.session.drive = false

but it wasn't working and then I found this issue which says to do the following:

import '@hotwired/turbo-rails'
Turbo.session.drive = false // disable turbo app wide and add for specific elements gradually

and it worked right away! So I'm not sure if the README needs to get updated, but figured I'd raise it for anyone else who runs into the issue.

@dhh
Copy link
Member

dhh commented Jun 20, 2023

Yeah, Turbo is now set on window by default. Please do make a doc update PR 👍

@dhh dhh closed this as completed Jun 20, 2023
dhh pushed a commit that referenced this issue Jun 24, 2023
As raised in #426, Turbo is set on the window by default so the import example is out-of-date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants