Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ? operator with conditional check #337

Merged
merged 1 commit into from May 24, 2022

Conversation

seanpdoyle
Copy link
Contributor

Closes #336

Address downstream Rails consumers' webpack syntax issues by replacing
the ? operator with a check that submitter is present.

Closes [hotwired#336][]

Address downstream Rails consumers' webpack syntax issues by replacing
the `?` operator with a check that `submitter` is present.

[hotwired#336]: hotwired#336
@davidrunger
Copy link

davidrunger commented May 23, 2022

Thanks! I have confirmed that this fixes the specific problem that I reported in #336. 👍 When I install @hotwired/turbo-rails via yarn add https://github.com/seanpdoyle/turbo-rails\#inline-conditional-chaining, bin/webpack now completes for me without any errors.

However, now that webpack is compiling and so I can run my test suite, I am seeing a newly failing feature test in the part of my app that uses turbo. I haven't yet had a chance to try to figure out what exactly is causing that test failure, though I plan to look into it ASAP. Presumably the test failure has something to do with the changes introduced in @hotwired/turbo-rails@7.1.2 / #239, but I don't yet know if it's something I am doing wrong on my end that is incompatible with @hotwired/turbo-rails@7.1.2 vs. a bug or unintended breaking change that might have been introduced into @hotwired/turbo-rails with that code change.

@davidrunger
Copy link

Scratch what I said above about a newly failing test in my test suite; I think it was just a flaky test. Upon re-running the test suite locally and running the test suite on my CI server, it passes. So this change seems good/fine to me! Thanks again.

@dhh dhh merged commit 37be2c6 into hotwired:main May 24, 2022
@dhh
Copy link
Member

dhh commented May 24, 2022

Released as 7.1.3 on npm 👍

@glaszig
Copy link

glaszig commented Sep 1, 2022

can i get a 1.1.2 of the gem as well please? ?. is tripping up my safari 12 as well :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants