Commits on Jul 19, 2022

1. Give html: rendering param the same treatment as content: …

   broadcast_action_to accepts a content: argument to set the
   turbo-stream template content directly, bypassing any rendering. Other
   params, like partial: or locals:  are delegated to render.
   
   Since the arguments are passed directly to render, you might expect you can
   also use html: as an argument here. However, there's a catch: when using
   a queue system to broadcast the action later, the html_safe flag of
   the html param might be lost in the serialization process. Specifically,
   the flag remains with queue backends that work in process (like `inline` or `async`)
   but it's lost in other that serialize the payload to JSON (like `resque`
   or `sidekiq`).
   
   The resulting effect is that the broadcast action works fine in
   development, but then fails when it's deployed to a production system.
   
   This problem seems to have tripped a few people:
   
   hotwired#284
   
   Treating html: the same as content: solves the issue.

   

   afcapel committed Jul 19, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 7749c6f
   • Browse repository at this point

   Copy the full SHA

   7749c6f View commit details

   Browse the repository at this point in the history