Don't assume fetchOptions has a body
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to run |
The event handler in encodeMethodIntoRequestBody was failing when forms were submitted using `method="GET"`, because it assumed the presence of `fetchOptions.body`, and such forms don't have a body. Checking for the presence of `body` before accessing it avoids the crash, and the resulting console noise.
|
Just realised that too :) Thanks! Clearly I've become too used to CI doing that sort of thing for me. |
dhh
added a commit
that referenced
this pull request
Sep 19, 2022
* main: Don't assume fetchOptions has a `body` (#384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event handler in
encodeMethodIntoRequestBodywas failing when forms were submitted usingmethod="GET", because it assumed the presence offetchOptions.body, and such forms don't have a body.Checking for the presence of
bodybefore accessing it avoids the crash, and the resulting console noise.