Allow passing extra params to native redirect URL #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the various redirect helpers, we allow passing the `:notice` option to the native redirection URL as a query param. However in some cases, apps may need to pass additional query parameters as well. This adds an optional `:native_params` option, which can be a hash of query params to add to the URL when redirecting on native. This option is ignored on other platforms. We also drop the special-case handling of `:native_notice` here, as that can now be more consistently handled inside `:native_params`.
kevinmcconnell
force-pushed
the
allow-additional-params-for-native-redirect
branch
from
6cf1ed6
to
6e35878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the various redirect helpers, we allow passing the
:noticeoption to the native redirection URL as a query param. However in some cases, apps may need to pass additional query parameters as well.This adds an optional
:native_paramsoption, which can be a hash of query params to add to the URL when redirecting on native. This option is ignored on other platforms.We also drop the special-case handling of
:native_noticehere, as that can now be more consistently handled inside:native_params.