Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cuprite #422

Merged
merged 1 commit into from Jun 20, 2023
Merged

Install cuprite #422

merged 1 commit into from Jun 20, 2023

Conversation

seanpdoyle
Copy link
Contributor

Execute System Tests through the CDP Protocol via cuprite.

This commit installs a dependency on cuprite@~>0.9 so that the js_errors: option is available. It was removed in subsequent releases, but its presence suits Turbo Rails well, since any JavaScript errors introduced by turbo-rails.js should fail the suite.

@seanpdoyle seanpdoyle force-pushed the cuprite branch 2 times, most recently from a303bc1 to d7bd577 Compare January 29, 2023 05:56
Execute System Tests through the CDP Protocol via [cuprite][].

This commit installs a dependency on [cuprite@~>0.9][] so that the
`js_errors:` option is available. It was removed in subsequent releases,
but its presence suits Turbo Rails well, since any JavaScript errors
introduced by `turbo-rails.js` should fail the suite.

[cuprite]: https://github.com/rubycdp/cuprite
[cuprite@~>0.9]: https://github.com/rubycdp/cuprite/tree/v0.9#customization
@dhh dhh merged commit a4b4620 into hotwired:main Jun 20, 2023
9 of 11 checks passed
@seanpdoyle seanpdoyle deleted the cuprite branch June 30, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants