Templates without .html aren't rendered #80
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #22 , there is a case when a view has no
.html
extension (.slim
instead of.html.slim
)While inspecting the request/response lifecycle in the browser I observed that the first load of the page doesn't have the
turbo-stream
mime type in the Accept header, however when the JS is loaded, subsequent requests have that header value present.Somewhere in the library code, this causes the
turbo:before-fetch-response
event called fromFetchRequest#receive
JS class to bepreventDefault()-ed
.If the template has a
.html
extension - response ceases to includeturbo-stream
in theContent-Type
headerCurrently, the PR removes
.html
extension fromviews/trays/index(.html.erb -> .erb)
and adds the Accept turbo-stream header request to the test suite.Would be happy to make the test green, however after going through all the ruby and JS codebase I cannot figure out where the hiccup might happen.