Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbo should update the URL before frames render #617

Closed
manuelpuyol opened this issue Jun 30, 2022 · 0 comments · Fixed by #618
Closed

Turbo should update the URL before frames render #617

manuelpuyol opened this issue Jun 30, 2022 · 0 comments · Fixed by #618

Comments

@manuelpuyol
Copy link
Contributor

When promoting a frame navigation with data-turbo-action, Turbo will render the Frame and then update the URL:

Screen.Recording.2022-06-30.at.11.13.54.AM.mov

Promoted frames should act like visits, where we update the URL first:

Screen.Recording.2022-06-30.at.11.15.18.AM.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the history before rendering promoted frames manuelpuyol/turbo
1 participant
@manuelpuyol