Skip to content

Commit

Permalink
Merge pull request #1711 from houdiniproject/update-to-node-16
Browse files Browse the repository at this point in the history
Update to Node 16
  • Loading branch information
wwahammy committed Mar 24, 2024
2 parents 337d759 + 1d6d08c commit 0195cfa
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-scanning.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true
env:
# this version used for running various tools
tool_node_version: "14.x"
tool_node_version: "16.x"
tool_ruby_version: "2.7.8"
jobs:
eslint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ jobs:
matrix:
os: [ubuntu-20.04]
ruby: [2.7.8]
node: [14.x]
node: [16.x]

2 changes: 1 addition & 1 deletion .github/workflows/single-matrix-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
type: string
env:
# this version used for running various tools
tool_node_version: "14.x"
tool_node_version: "16.x"
tool_ruby_version: "2.7.8"
jobs:
changes:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
14.19.1
16

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ All new backend code and React components should be well tested.

## Prerequisites

- Node.js 14 (we require 14 because we want the full internationalization built-in)
- Node.js 16 (we require 16 because we want the full internationalization built-in)
- Yarn
- PostgreSQL 12 (10 probably works)
- Ruby 2.7
Expand Down Expand Up @@ -97,7 +97,7 @@ apt install curl -yy
#### Node and Yarn install

```bash
curl -sL https://deb.nodesource.com/setup_14.x | bash -
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
apt update
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started_wsl2.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ apt install curl -yy
#### Node and Yarn install

```bash
curl -sL https://deb.nodesource.com/setup_14.x | bash -
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
apt update
Expand Down
2 changes: 1 addition & 1 deletion script/build/debian/node.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -e
curl -sL https://deb.nodesource.com/setup_14.x | bash -
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list

Expand Down

0 comments on commit 0195cfa

Please sign in to comment.