-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding getting started with wsl2 into docs #1546
Conversation
Co-authored-by: José Luís Ramos <78660807+joseluis-rt@users.noreply.github.com> Co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me! Did you verify this actually all works? 😄
@eduardomr quick tip for the future: If you put the line Closes # in your PR description up top, it will automatically close the the original issue when this PR is merged. It's super helpful! I'll do that for you this time but in the future, please do so yourself. |
Hey all, it looks like the markdown lint didn't quite work. The reason is probably because you, reasonably, copied this info from README.md and we specifically exclude README.md from linting right now. We won't worry about that this time but, in another PR, I encourage you to remove the exclusion for README.md and correct all of the markdown linting issues in both files. |
co-authored-by: Eduardo Maia <emaiarezende@gmail.com> co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com>
Co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com> Co-authored-by: Eduardo Maia <emaiarezende@gmail.com>
I apologize in advance if this question seems too basic, but I couldn't locate the exact file where this exclusion is being specified. Could you please guide me to the file responsible for removing the README file from the lint configuration? |
@eduardomr I just realized that the markdown linting config is not easy to modify. Could you file an issue which mentions we need to lint all of the markdown files in the repo and eliminate all of the exclusions? As part of that, you should mention it's not clear where the markdown linting exclusions are set. |
@wwahammy Okay! i'll open the issue |
Closes #1545