Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdownlint Bugfix #1594

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Markdownlint Bugfix #1594

merged 11 commits into from
Aug 17, 2023

Conversation

eduardomr
Copy link
Contributor

Closes #1560

eduardomr and others added 6 commits May 10, 2023 14:01
Co-authored-by: José Luís Ramos <78660807+joseluis-rt@users.noreply.github.com>
Co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com>
co-authored-by: Eduardo Maia <emaiarezende@gmail.com>
co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com>
Co-authored-by: Klyssmann Oliveira <56873266+klyssmannoliveira@users.noreply.github.com>
Co-authored-by: Eduardo Maia <emaiarezende@gmail.com>
@BenSturmfels
Copy link
Contributor

Thanks for the PR @eduardomr, @joseluis-rt, @klyssmannoliveira. The .github/workflows/pr.yml was just calling the command markdownlint from package.json, so I'd suggest making the change there instead. That way you'll also fix the npx markdownlint command when other developers run it from the command-line (not just in CI).

@eduardomr
Copy link
Contributor Author

Thanks for the feedback @BenSturmfels! We'll do the changes.

@BenSturmfels
Copy link
Contributor

Thanks for the feedback @BenSturmfels! We'll do the changes.

@eduardomr it would be great to get these changes transferred to package.json when you have a moment.

@BenSturmfels
Copy link
Contributor

@eduardomr that's great. Now please revert the change to .github/workflows/pr.yml and this will be good to go.

@wwahammy
Copy link
Member

Thanks @eduardomr and @BenSturmfels, I've gone ahead and corrected the pr.yml file and we should be able to merge the PR. Thanks for all of the help everyone!

@wwahammy wwahammy merged commit 1cb20da into houdiniproject:main Aug 17, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Markdown Lint Configuration
4 participants