This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
only append visible svg items in modal for perf, #8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first approach of how to handle a lot of svg items.
Items are absolutely positioned and only visible items are appended to the dom. Once an item become invisible it is added to a recycled_items array and reused later. With this solution there is roughly less than 50
<li>items in the<ul>, no matter how much icons are available.Without this change, opening the modal when there was 10'000 icons was making the browser nearly unresponsive (> 10 seconds), and searching was nearly impossible. With this first patch, opening, searching and scrolling feel instantaneous.