Give the config builder an appropriate name #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gylaz
approved these changes
Jan 6, 2017
Before, the config builder was a model and the name implied that it return an instance of a config builder. The config builder actually returned an instance of a specific config. Moved the class into the `services` directory and gave it a more appropriate name.
purinkle
force-pushed
the
rw-rename-config-builder
branch
from
80c3f92
to
ed77928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the config builder was a model and the name implied that it return an instance of a config builder. The config builder actually returned an instance of a specific config. Moved the class into the
servicesdirectory and gave it a more appropriate name.