Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO updates for homepage (title, meta, heading) #1318

Closed
wants to merge 1 commit into from
Closed

Conversation

jayroh
Copy link
Contributor

@jayroh jayroh commented Feb 15, 2017

No description provided.

@@ -1,4 +1,5 @@
- content_for :page_title, "Hound"
- content_for :page_title, "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more"
- content_for :meta_description, "Hound is the GitHub code review tool the thoughtbot team wanted but never got, so they built it. You can use it too. Now checking Ruby, JS, Swift, CoffeeScript, Go and more. "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [209/80]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could go do block style or move this to locales to hard wrap at 80 characters

@@ -1,4 +1,5 @@
- content_for :page_title, "Hound"
- content_for :page_title, "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [90/80]
4 consecutive Ruby scripts can be merged into a single :ruby filter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GitHub" (capital "H") everywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want "JavaScript" instead of "JS". If we do, we'd want to drop Swift or Elixir to stay within the 50-60 character SEO length guideline.

> "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more".size
=> 61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to drop Swift and keep Elixir, since customers for this are more likely to fall within that Elixir camp. Just a hunch

Copy link
Contributor

@croaky croaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -1,4 +1,5 @@
- content_for :page_title, "Hound"
- content_for :page_title, "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GitHub" (capital "H") everywhere

@@ -1,4 +1,5 @@
- content_for :page_title, "Hound"
- content_for :page_title, "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want "JavaScript" instead of "JS". If we do, we'd want to drop Swift or Elixir to stay within the 50-60 character SEO length guideline.

> "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more".size
=> 61

@@ -1,4 +1,5 @@
- content_for :page_title, "Hound"
- content_for :page_title, "Github Code Review Tool for JS, Ruby, Swift, Elixir, and more"
- content_for :meta_description, "Hound is the GitHub code review tool the thoughtbot team wanted but never got, so they built it. You can use it too. Now checking Ruby, JS, Swift, CoffeeScript, Go and more. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could go do block style or move this to locales to hard wrap at 80 characters

Per idea at growthhacker.com project:

https://projects.growthhackers.com/orgs/thoughtbot/projects/HOUND/cards/61504

> Home page <title> tag: "Hound - Github Code Review Tool for JS, Ruby, Swift, and more"
>
> Home page <meta> description: "Hound is the GitHub code review tool the
> thoughtbot team wanted but never got, so they built it. You can use it too.
> Now checking Ruby, JS, Swift, CoffeeScript, Go and more. "
>
> Home page copy: "Hound - a GitHub code review tool"
@jayroh jayroh closed this Feb 16, 2017
@jayroh jayroh deleted the jro-seo-tweaks branch February 16, 2017 01:34
@teoljungberg
Copy link
Contributor

For future reference, this was merged as 3d3b26c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants