-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Confirm dialogue #19
Comments
We think we have a way forward for this using built in classes. |
So, regarding the config schema, we should try to match the schema of lovelace as much as possible but we don't want to affect those currently using the app too much: Option 1 (less schema churn): {
"type": "tap",
"entity": "script.test",
"service": "script.turn_on",
"name": "Test!",
"confirm": true // optional (Boolean or Null)
} Option 2 (closer to homeassistant): {
"type": "tap",
"entity": "script.test",
"name": "Test!",
"tap_action": {
"service": "script.turn_on",
"confirm": true // optional (Boolean or Null)
}
}
Regarding implementation, we should be able to use the builtin |
As you say, I'm worried that Option 2 means schema churn. Its a pity that we did not think ahead a bit more when adding the Does that preference then land us in trouble going forwards? Will we wish we had bitten the bullet sooner and mirrored the HA schema more carefully? If so, we go for Option 2 without breaking the existing use of |
After a discussion, we have decided to move forward with option 2, while still supporting the previous The We plan to maintain backward compatibility far into the future so that we do not break user's configurations. |
One feature I'd like to request is a confirmation on entity activation. For example if I have a toggle/tap service that unlocks the door/opens garage door or similar it could be used. The confirm action should require a physical button press. The reason is to not to be able to accidentally trigger such entities by "ghost touches" by for example rain.
The text was updated successfully, but these errors were encountered: