Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 feature request confirm dialogue #20

Merged
merged 11 commits into from
Dec 1, 2023

Conversation

philipabbey
Copy link
Collaborator

Ready for review

JosephAbbey and others added 9 commits November 21, 2023 18:24
Added description of v1.4
Added credit
Adding some hints to avoid setup errors.
For optional confirmation dialogue box.
Also missed schema changes of the previous commit. Added a photo of the confirmation view.
Tidy up of help text
@philipabbey philipabbey linked an issue Dec 1, 2023 that may be closed by this pull request
Copy link
Member

@JosephAbbey JosephAbbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes

config.schema.json Outdated Show resolved Hide resolved
manifest.xml Outdated Show resolved Hide resolved
source/HomeAssistantView.mc Outdated Show resolved Hide resolved
Review comment about a random space.
Added missing full stops.
@JosephAbbey JosephAbbey merged commit ea58171 into main Dec 1, 2023
@JosephAbbey JosephAbbey deleted the 19-feature-request-confirm-dialogue branch January 5, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Confirm dialogue
2 participants