Use numeric level id in generated methods and elsewhere when we have it #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
force-pushed
the
autarch/sergle-rework
branch
from
7a9cc9e
to
e6f94bb
Compare
autarch
force-pushed
the
autarch/sergle-rework
branch
4 times, most recently
from
9347187
to
ebc2d0b
Compare
Instead of passing the level name around and turning it into a number over and over, we now turn it into a number once at a public method entry point and pass that number through to private methods instead of calling public methods again. This provides a speed increase in two ways. First, we do much less validation. Previously we would repeatedly validate the same set of args in many cases. Two, we only do the name->number lookup once.
autarch
force-pushed
the
autarch/sergle-rework
branch
from
9211be0
to
9915cd6
Compare
preaction
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing the level name around and turning it into a number over and
over, we now turn it into a number once at a public method entry point and
pass that number through to private methods instead of calling public methods
again.
This provides a speed increase in two ways. First, we do much less
validation. Previously we would repeatedly validate the same set of args in
many cases. Two, we only do the name->number lookup once.