Skip to content

Commit

Permalink
changes to glob stringification for 5.0050{34}
Browse files Browse the repository at this point in the history
  • Loading branch information
autarch committed Apr 4, 2004
1 parent b9a988d commit 2058649
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 3 deletions.
9 changes: 9 additions & 0 deletions Changes
@@ -1,3 +1,12 @@
0.74 April 4, 2004 (The "I hate old Perls" release)

- Sometimes, but not always, Perl 5.00504 and 5.00503 cannot produce a
string value for a glob (as opposed to glob reference) parameter.
This was uncovered by a test in the HTML::Mason test suite, but I
cannot reproduce it in a simple testable form for this test suite.
Sigh ...


0.73 Mar 28, 2004 (The "YAPC::Taipei release party" release)

- The minimum number of arguments required was reported incorrectly by
Expand Down
4 changes: 4 additions & 0 deletions TODO
Expand Up @@ -13,3 +13,7 @@ way.

- is there something better than "N/A" that could be used when
validation is being done outside a sub?


- add an excludes param to the spec as the opposite of depends,
suggested by Diab Jerius (see rt.cpan.org).
2 changes: 1 addition & 1 deletion Validate.xs
Expand Up @@ -937,7 +937,7 @@ cat_string_representation(SV* buffer, SV* value)
{
#if (PERL_VERSION == 5)
if (SvTYPE(value) == SVt_PVGV) {
sv_catpv(buffer, "GLOB/handle");
sv_catpv(buffer, "GLOB");
} else
#endif
if(SvOK(value)) {
Expand Down
2 changes: 1 addition & 1 deletion lib/Params/Validate.pm
Expand Up @@ -15,7 +15,7 @@ BEGIN

@ISA = 'Exporter';

$VERSION = '0.73';
$VERSION = '0.74';

my %tags =
( types =>
Expand Down
2 changes: 1 addition & 1 deletion t/01-validate.t
Expand Up @@ -29,7 +29,7 @@ use vars qw(@expect);

# funkier types
q|^The 'bar' parameter \("GLOB\(0x[a-f0-9]+\)"\) to main::sub4 was a 'globref'.* types: glob|,
q|^The 'baz' parameter \("\*main::FH"\) to main::sub4 was a 'glob'.* types: globref|,
q|^The 'baz' parameter \((?:"\*main::FH"\|GLOB)\) to main::sub4 was a 'glob'.* types: globref|,
q|^The 'foo' parameter \("foobar"\) to main::sub4 was a 'scalar'.* types: scalarref|,
q|^The 'quux' parameter \("GLOB\(0x[a-f0-9]+\)"\) to main::sub4 was a 'globref'.* types: coderef|,

Expand Down

0 comments on commit 2058649

Please sign in to comment.