Allow setting of individual properties from Uri in ConnectionFactory #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the version props to match 2.0.0 for the latest, @houseofcat - do you think there's a chance this could be merged before the release, please? I'm less fussed about the other two PRs (not including the BufferBlock changes for Dataflow, which I'm going to close for now anyway) but this one would be really useful, and isn't currently possible to override due to the nature of the ConnectionPool constructor and virtuals. |
houseofcat
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For when having weird and wonderful usernames and/or passwords without having the pain of escaping them etc.