Skip to content

Commit

Permalink
fix: rebalance issue
Browse files Browse the repository at this point in the history
    - risk of int overflow
    - rebalance by offset and partition
  • Loading branch information
YenchangChan committed May 6, 2024
1 parent d379713 commit 0c42c38
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion task/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (service *Service) Put(msg *model.InputMessage, traceId string, flushFn fun
util.Logger.Fatal("shard number calculation failed", zap.String("task", taskCfg.Name), zap.Error(err))
}
} else {
msgRow.Shard = int(msgRow.Msg.Offset>>service.offShift) % service.sharder.shards
msgRow.Shard = int(msgRow.Msg.Offset * (int64(msgRow.Msg.Partition + 1)) >> service.offShift % int64(service.sharder.shards))
}
service.sharder.PutElement(&msgRow)
}
Expand Down

0 comments on commit 0c42c38

Please sign in to comment.