Add multiple quantization params per tensor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinghai
reviewed
Apr 16, 2019
foxi/onnxifi.h
Outdated
| /** | ||
| * Indicates the axis along which quantization parameters are shared. | ||
| */ | ||
| uint32_t quantizationAxis; |
There was a problem hiding this comment.
nit: put quantizationAxis before quantizationParams so that we know that quantizationParams specifies the lengths of scales and biases which follows immediately after?
jackm321
force-pushed
the
multi_quant_params
branch
from
068a5ec
to
1048d00
Compare
|
@houseroad @yinghai @jackm321 Please dont sync back foxi for now, since this will break everything related to quantization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.