Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Faraday compatibility #12

Closed
mezis opened this issue Jul 23, 2014 · 4 comments
Closed

Fix Faraday compatibility #12

mezis opened this issue Jul 23, 2014 · 4 comments
Labels
backlog enhancement

Comments

@mezis
Copy link
Contributor

mezis commented Jul 23, 2014

Faraday 0.8.9 and 0.8.4 have incompatibilities. #9 is not acceptable (locks old Faraday version).

Make the client code work with both, use appraisal to test.
@adamof
Copy link
Contributor

adamof commented Jul 24, 2014

Is this what you refer to by appraisal? - https://github.com/thoughtbot/appraisal

@adamof
Copy link
Contributor

adamof commented Jul 24, 2014

The breaking changes are actually between 0.8.9 and 0.9.0
0.8.9:

req.options[:timeout] = 5

0.9.0:

req.options.timeout = 5

@adamof
Copy link
Contributor

adamof commented Jul 24, 2014

Latest news: it's not a breaking change actually, it's just that I have used the new gem locally when developing

@adamof adamof mentioned this issue Jul 24, 2014
Merged
@mezis
Copy link
Contributor Author

mezis commented Jul 24, 2014

Fixed by #13.

@mezis mezis closed this as completed Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mezis @adamof