Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start using querySystemIdleTime upon update to electron@3.0.0 #258

Closed
lundibundi opened this issue Jun 30, 2018 · 2 comments · Fixed by #447
Closed

start using querySystemIdleTime upon update to electron@3.0.0 #258

lundibundi opened this issue Jun 30, 2018 · 2 comments · Fixed by #447

Comments

@lundibundi
Copy link
Contributor

New electron version added chromium bindings for system idle time so consider using them upon update to the new Electron. (Electron release notes)

Also, I tried updating electron in stretchly to beta version and it seemed to work just fine, though I couldn't get paulcbetts/node-system-idle-time to work properly, so I just disabled natural breaks in configuration. Other than that I haven't noticed any issues, though I didn't thoroughly checked it.
@hovancik
Copy link
Owner

hovancik commented Jul 1, 2018

If it works correctly and on all systems, it would be great to get rid of paulcbetts/node-system-idle-time

@hovancik hovancik mentioned this issue Jul 31, 2018
Closed
@hovancik
Copy link
Owner

hovancik commented Nov 1, 2018

Small update: there is a bug with electron 3: electron/electron#15161 so I am still using version 2 for now.

@hovancik hovancik mentioned this issue Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove system-idle-time and update deps hovancik/stretchly
2 participants
@hovancik @lundibundi