Fix cache when we have time out with navitia. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sami602
approved these changes
Feb 20, 2024
sami602
approved these changes
Feb 20, 2024
pthegner
approved these changes
Feb 20, 2024
sami602
reviewed
Mar 4, 2024
| $ch = new CurlService($url, $this->timeout, $token, $this->logger); | ||
| $result = $ch->process(); | ||
| $this->cache->setCacheItem($cacheKey, $result); | ||
| if ($result['httpCode'] === 200) { |
There was a problem hiding this comment.
I think we should update this line to
if ($result['httpCode'] === 200 && $result['response'] !== false && empty($result['errorMsg'])) {
to avoid this case (a 200 response but with a timeout error) :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cache when we have time out with navitia.
Reference