[Distributed] Timeout when direct path takes too long #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlqian
changed the title
|
xlqian
changed the title
pbench
reviewed
Mar 27, 2024
source/jormungandr/jormungandr/scenarios/helper_classes/streetnetwork_path.py
Show resolved
Hide resolved
pbench
approved these changes
Mar 27, 2024
azime
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Distributed, the direct path is the very first step performed by the algorithm and the process will NOT carry on until this step finishes. In cases where a VERY long direct path is required, serval hundreds of ms may elapse before Distributed could keep on.
The idea here is not to wait too long in the sections where the direct path is dispensable.
The chosen default timeout(100ms) is wholly empirical.