Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix since until for line report API #4258

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Fix since until for line report API #4258

merged 4 commits into from
Apr 3, 2024

Conversation

azime
Copy link
Contributor

@azime azime commented Apr 2, 2024 •
edited by jira bot

Jira: NAV-2695

Before correction:
image

After correction:
image

@azime azime requested review from adrien3d, xlqian and pbench April 2, 2024 13:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@azime azime requested a review from kadhikari April 3, 2024 10:10
kadhikari
kadhikari approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@kadhikari kadhikari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Since and until should filter impacts depending on application_period but not publication_period
  • publication_period is used while loading impacts from BDD chaos or RMQ.

@azime azime merged commit 7b21ffe into dev Apr 3, 2024
9 checks passed
@azime azime deleted the fix_since_until_line_reports branch April 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadhikari kadhikari kadhikari approved these changes

@xlqian xlqian xlqian approved these changes

@pbench pbench pbench approved these changes

@adrien3d adrien3d Awaiting requested review from adrien3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@azime @kadhikari @xlqian @pbench